Missing "edit" links

19wolf

I have ₁₅ variables in my template, all of which I intend to be editable from the "in-page edit" function. However, only two edit buttons appear.

https://www.dropbox.com/s/1fbi60d8nfpval4/Screenshot%202019-12-22%2021.41.27.png?dl=0

In the screenshot, you can see the edit button on the title and subtitle, but not on the cards. There doesn't appear to be any code injected into the html for those elements either, so it's not a weird css issue.

mad

19wolf Hi, I guess the cards are wrapped by anchor tags. Variables within in those tags don't have edit buttons since it is not possible to have an anchor tag within another anchor tag. That would not be valid HTML. You can also see my comment on the issue on GitHub for a more detailed list of cases, where there are no edit buttons available.

19wolf

So here's a sample of one of the cards:

<article class="card">
	<img src="@{ image1-link }"/>
	<h1>@{ card1-title }</h1>
	<p>@{ card1-text }</p>
</article>

I'm guessing it might have something to do with the "article" tag beginning with an 'a'? I won't be able to test it until late tonight (EST)

mad

19wolf Hi, I think you’re completely right! The article tag is here misinterpreted as an a. It will be fixed in the next release. 😜

However — for now you could resolve the issue by replacing the article tag with a div.

Cheers!

mad

19wolf Hi! After investigating a bit more it turns out that the article is actually interpreted correctly. Therefore the @{ card1-title } and @{ card1-text } should have edit buttons. The @{ image1-link } is located within an HTML tag and therefore has no edit button.

So the question is, what could be wrong here. Is it possible that the article itself is wrapped in an a? If not, I will investigate further ...

19wolf

I don't believe there are any 'a' tags on the page, save for the email at the bottom and my name in the footer.Check it out, maybe I missed something. Unfortunately, (as above) I won't be able to access the back end until tonight.

Also yes, I'm not expecting the image to be editable on the front-end

mad

19wolf Ok, take your time. 😃
I will try to reproduce the issue in the mean time.

mad

19wolf Hi, I was able to reproduces the issue. Your guess was right and can confirm it. I will try to fix it after Christmas. So stay tuned!